Conversation
Member
|
Just to confirm, you tested that this works on Windows? I noticed the original test was masked on Windows. |
Member
Author
|
@headius I tried it and it does not seem to work so I should probably mask it out until I can figure that out. This is plain old Java socket stuff so I half wonder if this ever worked on windows. The reporter implied it used to work but I guess I need to try 1.7 and see. |
kares
approved these changes
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #5656. I could not get the reporters server code to work on linux much less the other platforms referenced. I believe it was something underneath this source line in original code:
in Java source of getChannel() is literally 'return null'. Based on changes over the years I suspect something changed in our implementation (like maybe we subclassed the channel?). This version just uses the socket itself to receive and it blocks and also seems to work. I also added the equivalent logic if somehow the socket is in a messed up state and tried to mark itself as non-blocking.
With that said I am not confident so I need some eyeballs...