Use close_on_exec method instead of using fcntl calls for pty. Fixes #5663#5677
Merged
enebo merged 1 commit intojruby:masterfrom Apr 5, 2019
Merged
Use close_on_exec method instead of using fcntl calls for pty. Fixes #5663#5677enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
Member
|
👍 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix as suggested in #5663. Provides same behavior as MRI now.
Additionally, I ran this test:
jruby -r ./test/mri/lib/envutil.rb test/mri/test_pty.rband it passed. I wasn't sure if I needed to to anything else, or why https://github.com/jruby/jruby/blob/master/test/mri/excludes/TestPTY.rb suggests that it should fail.This also doesn't address the opposite behavior of the nonblock flag as I noted in #5663
Resolves #5663