Additional pack/unpack optimizations#5651
Merged
headius merged 3 commits intojruby:masterfrom Mar 13, 2019
Merged
Conversation
This is similar in nature to the changes in jruby#5647 but there's no specific performance regression I'm fixing here. We have seen issues with switch optimization across numerous JVM versions, so this seems like a good idea. It also makes the code easier to follow.
Reduces overhead of unpack1 from two blocks to one.
Member
Author
|
See #5647 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple more items for pack/unpack:
This may produce a small improvement in pack performance, but mostly it's to preemptively deal with JVMs that have trouble with large switches or methods, and also to make the code a bit easier to read.