[fix] properly calculate warning ($VERBOSE) default#5602
Merged
Conversation
... since warnings should not be printed by default
Member
|
@kares did you happen to find any tests about this tri-state nature? I think we can land this in 2.5 if you want as well. I agree this is probably pretty minor since no one reported but if we got some coverage it can definitely go in for 9.2.7.0. |
Member
Author
|
have not looked for a test but due warnings from |
Member
|
@kares then we can 2.6 and figure out if we want to cherry pick later. |
Member
|
Have we seen this happening with 9.2? It seems to be doing the right thing right now. |
Member
Author
|
@headius confused, what is doing the right thing ... is this redundant than for 9.2 or shall we back-port? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed this while implementing the deprecation warning
Object#=~for 2.6the 3 state warning level was only using true/false states so it ended up printing warnings by default
JRuby should keep a
nil(falsy) warning level by default, as Verbosity enum was intended tono one complained about this on 9.1/9.2 so I am targeting 2.6 for now, its present on 9.2 as well