Merged
Conversation
if not smt went wrong (before) and we shall fail with AIOoBE
... so that it's much easier to follow the C logic
... also aligned code to better match up MRI's
... and other non-to_int convertibles (like MRI)
JRuby does not pass one assert - they're excluded from MRI suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JRuby's Sprintf implementation is a bit out-of-date (compared to MRI's sprintf.c)
it's hard to add new functionality or identify incompatibilities/bugs (realized while #5556)
there's a few renames and code re-arranging in the direction of sprintf.c (based on ruby_2_5 branch)
and also some long-term fixes - resolves #2160, support for multi-byte characters with precision %s format