Skip to content

[fix] interpret today TZ-relative but use GJ chrono#5581

Merged
enebo merged 1 commit intojruby:masterfrom
kares:date-today-zone-fix
Jan 29, 2019
Merged

[fix] interpret today TZ-relative but use GJ chrono#5581
enebo merged 1 commit intojruby:masterfrom
kares:date-today-zone-fix

Conversation

@kares
Copy link
Member

@kares kares commented Jan 29, 2019

this should match the logic that was in place in 9.1.17.0
... expected to, finally and properly, resolve GH-5418
(reverts previous attempt #5560 - which reverted d6a93ce)

@enebo or @headius when merging please run test:jruby and test:mri:core on the branch
since CI is UTC - pretty confident it should be all good but just to double check.

this should match the logic that was in place in 9.1.17.0
expected to, finally and properly, resolve jrubyGH-5418
@kares kares added this to the JRuby 9.2.6.0 milestone Jan 29, 2019
@enebo enebo merged commit 8f0ada6 into jruby:master Jan 29, 2019
@enebo
Copy link
Member

enebo commented Jan 29, 2019

@kares ran locally and both those passes. Thanks for the extra efforts today. I will start examining if we are 9.2.6.0-ready in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date.today does not appear to take the local TZ into account

2 participants