fix float formating regression (half-even rounding)#5580
Merged
enebo merged 3 commits intojruby:masterfrom Jan 29, 2019
Merged
Conversation
e.g. 0.25 -> 0.2 0.2500 -> 0.2 0.2501 -> 0.3 resolves jrubyGH-5556
one based on jruby#5556 and the other based on https://bugs.ruby-lang.org/issues/12889.
since this seems to be a failure point for JRuby (jrubyGH-5556)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5556
relates to introducing half even rounding (as identified in the issue): bc2ba39
... which need some special care to only apply if there's no tail left
credits to @lassiter for identifying the 'breaking' commit + putting up tests