Ruby 2.6: Add support for endless range in more methods#5552
Merged
enebo merged 4 commits intojruby:ruby-2.6from Jan 10, 2019
Merged
Conversation
For more information, please see feature #12912.
For more information, please see feature #12912.
For more information, please see feature #12912.
For more information, please see feature #12912.
Member
|
@nomadium hey fixed the :fast problem with spec runs...should be a new batch of errors! |
Contributor
Author
|
@enebo Excellent, thanks for fixing it! I was a little puzzled because the error message is not evident at all (at least for me). |
nomadium
deleted the
ruby-2.6-add-support-for-endless-range-in-more-methods
branch
Member
|
@nomadium once I looked at the error message and the fact we have the same exact string on master I realized our spec config file had the ruby version in the name....seems somewhat unneeded in how we test now but in the past we would test multiple ruby versions in same release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
This PR iterates on the changes introduced on #5540.
Summary:
Make Range#min, max, include?, cover?, and === to support endless range
Range#to_a now raises RangeError if it is endless
Range#size now returns Float::INFINITY if it is endless
Range#last and #max raises a RangeError if it is endless
For more information, please see feature #12912. [1]
For reference, I include links to similar commits in MRI: [2] [3] [4] [5].
Thanks for the feedback.