Merged
Conversation
For more information, please see feature #12912.
For more information, please see feature #12912.
Member
|
@nomadium awesome JAY GENERATION!! :) Thanks for updating this. I am on xmas break and was bothered this syntax was not added before I went on it. |
Contributor
Author
|
@enebo No problem, I'm glad to be able to contribute! I found that feature interesting since it's the first time I implement a change in jruby that required me to make changes to the syntax. So, it's really cool to get it right. On a different topic, for some reason the spec:fast test suite is failing in ruby-2.6 branch so I'll take a closer look to that so see what's wrong. Enjoy your break! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
This PR implements another Ruby 2.6 language feature: Introduce endless ranges.
For more information, please see feature #12912. [1]
All its related tests are passing. [2] .. [19]
For reference, I include a link to the commit introducing the functionality in MRI. [20]
Thanks in advance for any feedback.
Note: Other methods in the Range class require changes to support or raise errors on endless ranges (e.g. #last, #max, #size and #to_a). I'll address that in subsequent commits or in a different PR. This PR is already long enough and I wanted to gather feedback to check if I'm going in the right direction.