Skip to content

Ruby 2.6: Add Dir instance methods #each_child and #children#5535

Merged
kares merged 2 commits intojruby:ruby-2.6from
nomadium:ruby-2.6-add-dir-instance-each-child-and-children
Feb 4, 2019
Merged

Ruby 2.6: Add Dir instance methods #each_child and #children#5535
kares merged 2 commits intojruby:ruby-2.6from
nomadium:ruby-2.6-add-dir-instance-each-child-and-children

Conversation

@nomadium
Copy link
Contributor

Hi folks,

This PR implements another Ruby 2.6 feature: Add Dir new instance methods #each_child and #children.

For more information, please see feature #13969. [1]

All its related tests are passing. [2]

For reference, I include a link to the commit introducing the functionality in MRI. [3]

Thanks in advance for any feedback.

  1. https://bugs.ruby-lang.org/issues/13969
  2. https://github.com/ruby/ruby/blob/v2_6_0_rc2/test/ruby/test_dir.rb#L268-L278
  3. ruby/ruby@6a3a7e9

For more information, please see feature #13969.
For more information, please see feature #13969.
@nomadium nomadium force-pushed the ruby-2.6-add-dir-instance-each-child-and-children branch from 4ac5f09 to e789450 Compare January 11, 2019 17:39
@kares kares added the ruby 2.6 label Jan 20, 2019
@kares kares merged commit 3817676 into jruby:ruby-2.6 Feb 4, 2019
@kares
Copy link
Member

kares commented Feb 4, 2019

👍 checked at #5576

@nomadium nomadium deleted the ruby-2.6-add-dir-instance-each-child-and-children branch February 4, 2019 19:27
@enebo enebo added this to the JRuby 9.3.0.0 milestone Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants