Limit the width of reified objects to 50 by default.#5518
Merged
headius merged 3 commits intojruby:masterfrom May 15, 2019
Merged
Limit the width of reified objects to 50 by default.#5518headius merged 3 commits intojruby:masterfrom
headius merged 3 commits intojruby:masterfrom
Conversation
This relates to jruby#5511 but is not a fix. This only limits how wide these object will be, so we're not generating extremely wide classes for weirdly dynamic objects that create lots of new instance variables. This will be improved once we make objects know about their own shapes, so they can evolve to handle the right number of variables that are actually used.
Member
Author
|
cc @guizmaii |
Member
Author
|
Ok looks like additional work needed...it's trying to grab vars at widths outside the max. |
This fixes the remaining issues with the previous change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to #5511 but is not a fix. This only limits how wide
these object will be, so we're not generating extremely wide
classes for weirdly dynamic objects that create lots of new
instance variables.
This will be improved once we make objects know about their own
shapes, so they can evolve to handle the right number of variables
that are actually used.