Skip to content

Backward traces#5510

Closed
headius wants to merge 1 commit intojruby:masterfrom
headius:backward_traces
Closed

Backward traces#5510
headius wants to merge 1 commit intojruby:masterfrom
headius:backward_traces

Conversation

@headius
Copy link
Member

@headius headius commented Dec 12, 2018

Work in progress to implement backward traces and newer MRI formatting and highlighting from Ruby 2.5.

The relevant tests will be tagged for the stdlib merge in #5505.

@headius headius added this to the JRuby 9.2.6.0 milestone Dec 12, 2018
@headius
Copy link
Member Author

headius commented Dec 13, 2018

Tests were excluded in fcb6cdb and 58d5a2e.

I've expanded the bug to include the use of backtrace from full_message which appears to have been tweaked in https://bugs.ruby-lang.org/issues/14756. We call backtrace but only appear to use the first line from it, and do not error if it is of the wrong type. We do not crash like MRI, of course.

headius added a commit to headius/jruby that referenced this pull request Dec 13, 2018
@headius headius modified the milestones: JRuby 9.2.6.0, JRuby 9.2.7.0 Dec 18, 2018
@headius headius modified the milestones: JRuby 9.2.7.0, JRuby 9.3.0.0 Apr 9, 2019
@headius headius mentioned this pull request Aug 6, 2019
12 tasks
@headius
Copy link
Member Author

headius commented Apr 6, 2021

This appears to have been reverted in CRuby (thank goodness) according to @jeremyevans here: https://bugs.ruby-lang.org/issues/14558#note-5

The referenced hash does not appear to link to the reversion but I have asked for clarification. In any case, I am closing this and we will not support it (unless someone really demands we add the option in the future).

@headius headius closed this Apr 6, 2021
@headius headius modified the milestones: JRuby 9.3.0.0, Won't Fix Apr 6, 2021
@headius headius deleted the backward_traces branch April 6, 2021 22:59
@headius
Copy link
Member Author

headius commented Apr 6, 2021

Proper hash for the reversion is ruby/ruby@487d0c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant