review thread sync and clear references#5506
Merged
kares merged 8 commits intojruby:masterfrom Dec 15, 2018
Merged
Conversation
also clear out ref when setting null (happens on thread dispose)
this piece gets invoked on RubyThread#dispose (finalize) thus shall not attempt to adopt thread with getCurrentContext ... at the point this gets invoked refs should be null
headius
requested changes
Dec 13, 2018
Member
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
Seems generally ok but I had a few questions.
kares
force-pushed
the
proper-thread-sync
branch
from
b1544cf to
47a9e5e
Compare
kares
force-pushed
the
proper-thread-sync
branch
from
47a9e5e to
67aab5d
Compare
unifies the un-registering logic for normal threads vs fibers also cache volatile data in a local (its assigned on initialize)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.getCurrentContextthe initial motivation was to avoid some soft-references as with tons of fibers they won't get collected until a full gc is run. might still try to look into that direction, these changes should be conservative and maybe help clearing some of those refs (as fibers are done).