improved error message for "wrong number of arguments"#5491
Merged
enebo merged 2 commits intojruby:masterfrom Dec 3, 2018
Merged
improved error message for "wrong number of arguments"#5491enebo merged 2 commits intojruby:masterfrom
enebo merged 2 commits intojruby:masterfrom
Conversation
7baf23b to
4712f3a
Compare
Member
|
This should be squashed when merged. Let us know when you're satisfied 😀 |
Member
|
@ahorek travis is pretty unhappy with some Enumerator arity errors. Perhaps something in this PR changed some arity checking? |
Contributor
Author
|
yeah, there're still some cases that don't work as expected, I'll let you know when it's ready |
Member
|
@ahorek ok. Thanks for fixing this... It has been an annoyance that the format was old |
602878a to
7ae5d71
Compare
Contributor
Author
Member
|
@ahorek looks pretty straight-forward...just merged it |
Member
|
This appears to be breaking at least one spec that expects no method name in the message: We probably should just drop the method name. |
headius
added a commit
that referenced
this pull request
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #5475