[fix] RubyException#toJava(Object) shouldn't return null#5488
Merged
Conversation
... a regression since the exception hierarchy rewrite in 9.2 spotted at: sparklemotion/nokogiri#1818 for compat `rubyException.toJava(Object.class)` shall return self
Member
Author
|
NOTE: no strong opinions against changing the behaviour of this PR simply restores pre 9.2 ... with the new exception hierarchy it might make sense to convert by default. most Java convertable types do the coercion e.g. |
Member
|
I agree with making Object on down all return the throwable. 9.3? @enebo |
Member
Member
Author
|
okay - opened #5498 targeting 9.3 so its not forgotten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... a regression since the exception hierarchy rewrite in 9.2
spotted at: sparklemotion/nokogiri#1818
for compat
rubyException.toJava(Object.class)shall return self