Skip to content

Add Array#difference#5469

Merged
enebo merged 1 commit intojruby:ruby-2.6from
nomadium:ruby-2.6-add-array-difference
Nov 27, 2018
Merged

Add Array#difference#5469
enebo merged 1 commit intojruby:ruby-2.6from
nomadium:ruby-2.6-add-array-difference

Conversation

@nomadium
Copy link
Contributor

Analogous to #5464.

I was reviewing some new features and decided to take a shot with implementing new Array#difference method.

The implementation is based on what they did in MRI [1] and is passing all its related tests [2].

For more information, please see feature #14097 [3].

Thanks in advance for any feedback.

  1. ruby/ruby@d65d553
  2. https://github.com/ruby/ruby/blob/v2_6_0_preview3/test/ruby/test_array.rb#L279-L298
  3. https://bugs.ruby-lang.org/issues/14097

@nomadium nomadium changed the base branch from master to ruby-2.6 November 26, 2018 19:27
For more information, please see feature #14097.
@nomadium nomadium force-pushed the ruby-2.6-add-array-difference branch from 1255268 to 7706228 Compare November 26, 2018 19:29
@enebo enebo added this to the JRuby 9.3.0.0 milestone Nov 27, 2018
@enebo enebo merged commit 396a0bf into jruby:ruby-2.6 Nov 27, 2018
@nomadium nomadium deleted the ruby-2.6-add-array-difference branch November 28, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants