Conversation
Member
|
oh really, does it fix those warnings, like all of them? now, I am a bit confused, do you know why is that? |
Contributor
Author
|
I know, you changed the default version to 1.8 in 1b10d61#diff-f1a3566fb02f3f96df7df320d1a2a669 this condition now fails on java 10, 11 |
Member
|
right, that makes sense - guess its one warning at a time than :)
... so maybe the |
headius
approved these changes
Dec 13, 2018
Member
|
Thank you! |
kares
added a commit
to kares/jruby
that referenced
this pull request
Dec 27, 2018
this constant is changeable using -Xbytecode.version=9 so its poorly named, use safer detection of Java 9+ follow-up on jrubyGH-5462 (merged from f8899fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes warnings
WARNING: Illegal reflective access by org.jruby.util.SecurityHelper to field java.lang.reflect.Field.modifiers
WARNING: Please consider reporting this to the maintainers of org.jruby.util.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release