Skip to content

Add a CI job for the "sequel" gem - #5432

Merged
headius merged 9 commits into
masterfrom
sequel_job
Nov 9, 2018
Merged

headius merged 9 commits into
masterfrom
sequel_job

Conversation

@headius

@headius headius commented Nov 9, 2018

Copy link
Copy Markdown
Member

This PR adds a job based on the CI runs for @jeremyevans Sequel library. I've basically just duplicated his .travis.yml in a shell script that's run along with our other jobs.

@headius

headius commented Nov 9, 2018

Copy link
Copy Markdown
Member Author

Note this should be squashed when merged; there's a lot of fiddling around in there.

@headius

headius commented Nov 9, 2018

Copy link
Copy Markdown
Member Author

I've added in the remaining environment setup and reduced clone depth to 10.

@jeremyevans This is currently running against your master HEAD. Is there a stable branch or tag you'd recommend we use instead? Maybe we query rubygems.org for latest release?

@jeremyevans

Copy link
Copy Markdown
Contributor

I'm OK with you running against the master branch. I generally do the same testing locally that Travis does on the latest released version of JRuby, so there is rarely breakage that would be caused by Sequel and not JRuby. That being said, using the latest rubygems.org release is probably safer and will result in fewer false positives.

kares pushed a commit to kares/jruby that referenced this pull request Nov 9, 2018
* Add a mapping from number to name.
* Generate mappings of name to number and number to name once, so
  we are only iterating the Signal enum in one place.
* Omit undefined signals on the current platform. This is how a bad
  value snuck in for jruby#5432.
* Force Windows to always define KILL as 9, even though SIGKILL is
  not defined on Windows.
@headius

headius commented Nov 9, 2018

Copy link
Copy Markdown
Member Author

@jeremyevans I think we'll just cross that bridge when we come to it. Thanks!

@headius
headius merged commit bc19f6c into master Nov 9, 2018
@headius
headius deleted the sequel_job branch November 9, 2018 17:14
@headius headius modified the milestones: JRuby 9.2.4.0, Non-Release Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants