Repository navigation
Clean up signal mapping and force KILL to 9 on Windows. Fix #5423. - #5430
Merged
Merged
Conversation
* Add a mapping from number to name. * Generate mappings of name to number and number to name once, so we are only iterating the Signal enum in one place. * Omit undefined signals on the current platform. This is how a bad value snuck in for jruby#5432. * Force Windows to always define KILL as 9, even though SIGKILL is not defined on Windows.
enebo
approved these changes
Nov 7, 2018
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we are only iterating the Signal enum in one place.
value snuck in for Process.kill(:KILL, $$) doesn't work on Windows #5423.
not defined on Windows.