Skip to content

Clean up signal mapping and force KILL to 9 on Windows. Fix #5423. - #5430

Merged
headius merged 2 commits into
jruby:masterfrom
headius:windows_kill
Nov 7, 2018
Merged

headius merged 2 commits into
jruby:masterfrom
headius:windows_kill

Conversation

@headius

@headius headius commented Nov 7, 2018 •

Copy link
Copy Markdown
Member
  • Add a mapping from number to name.
  • Generate mappings of name to number and number to name once, so
    we are only iterating the Signal enum in one place.
  • Omit undefined signals on the current platform. This is how a bad
    value snuck in for Process.kill(:KILL, $$) doesn't work on Windows #5423.
  • Force Windows to always define KILL as 9, even though SIGKILL is
    not defined on Windows.

* Add a mapping from number to name.
* Generate mappings of name to number and number to name once, so
  we are only iterating the Signal enum in one place.
* Omit undefined signals on the current platform. This is how a bad
  value snuck in for jruby#5432.
* Force Windows to always define KILL as 9, even though SIGKILL is
  not defined on Windows.
@headius headius added this to the JRuby 9.2.2.0 milestone Nov 7, 2018
@headius
headius requested a review from enebo November 7, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants