Attempt to fix #5421 windows oddity where some times a rename during bundle…#5429
Merged
Attempt to fix #5421 windows oddity where some times a rename during bundle…#5429
Conversation
… install would fail. The fix is I think if we depend on Files.move to do it's thing we should not try and rename a second time using the old way. This happened to never manifest on linux or macos because bundler stores files in another FS so we never hit this code path.
Contributor
|
LGTM, confirmed locally |
headius
approved these changes
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… install would fail.
This I believe fixes #5421.
The fix is I think if we depend on Files.move to do it's thing we should not
try and rename a second time using the old way. This happened to never
manifest on linux or macos because bundler stores files in another FS so
we never hit this code path.