More robust way to detect atomic move failure. Fixes #5415.#5416
Closed
headius wants to merge 0 commit intojruby:masterfrom
Closed
More robust way to detect atomic move failure. Fixes #5415.#5416headius wants to merge 0 commit intojruby:masterfrom
headius wants to merge 0 commit intojruby:masterfrom
Conversation
Contributor
|
confirmed! thanks |
Member
Author
enebo
requested changes
Nov 6, 2018
Member
enebo
left a comment
enebo
left a comment
There was a problem hiding this comment.
I think we should just put the EXDEV fix in this alone for 9.2.1.0 and then put the rest in after release. All our other string matches have been working for years without complaint and I don't want to add another variable of uncertainty for 9.2.1.0. 9.2.2.0 can hopefully have a little bake and we can have some confidence that the rest of this is solid (which I suspect it is but I am a bit paranoid this week).
Merged
headius
force-pushed
the
fix_exdev_error
branch
from
b0842df to
7b14404
Compare
Member
Author
|
I moved the other two commits to #5417 and merged in just the EXDEV fix for 9.2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It must have escaped my notice when improving the
EXDEVerror propagation that the JDK does have a specific error type for failed atomic moves. This logic should work on all OpenJDK 7+ based JDKs.@ahorek If you can confirm this works for you locally (I have confirmed it myself on MacOS) it would be a big help!