Conversation
|
no response from authors ... so let's kill it, shall we 😈 |
|
I think these are null checks. It's a pattern I don't agree with, but @ahorek @kares I think we should restore these with comments or just make them old-fashioned null checks. |
|
in a way they were is just weird, most of them will fail with a |
|
@headius could you add a test case to confirm these checks are necessary? assert != null sounds better... |
|
I went ahead with the asserts in 84be473. @ahorek It may be possible to prove these never receive null but I figured we should put the checks back for now anyway. Obviously these have not been firing for normal JRuby users or we'd have seen the NPE bug reports. Asserts add to bytecode size but will not execute normally, so this seems ok. And these do need to be be non-null, so having the asserts is appropriate. |
dead code?