Skip to content

synchronize RubyHash#iteratorExitSync#5409

Merged
kares merged 1 commit intojruby:masterfrom
ahorek:sync
Nov 13, 2018
Merged

synchronize RubyHash#iteratorExitSync#5409
kares merged 1 commit intojruby:masterfrom
ahorek:sync

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Nov 3, 2018

I think iteratorExitSync should be synchronized like iteratorEntrySync?

private volatile int iteratorCount;

private synchronized void iteratorEntrySync() {
    ++iteratorCount;
}
private void iteratorExitSync() {
    --iteratorCount;
}

@ahorek ahorek changed the title synchronize iteratorExitSync synchronize RubyHash#iteratorExitSync Nov 3, 2018
@kares kares merged commit 6daddcc into jruby:master Nov 13, 2018
@kares kares added this to the JRuby 9.2.4.0 milestone Nov 13, 2018
@enebo enebo modified the milestones: JRuby 9.2.4.0, JRuby 9.2.5.0 Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ahorek @enebo @kares