Fixing coercion case for subtraction from BigDecimal. Fixes #5386.#5391
Merged
kares merged 2 commits intojruby:masterfrom Oct 31, 2018
Merged
Fixing coercion case for subtraction from BigDecimal. Fixes #5386.#5391kares merged 2 commits intojruby:masterfrom
kares merged 2 commits intojruby:masterfrom
Conversation
kares
reviewed
Oct 31, 2018
Member
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
good job, please move the test and should be good to go (into 9.2.1)
| assert_kind_of(BigDecimal, BigDecimal("3") - 1.quo(3)) | ||
| end | ||
|
|
||
| def test_sub_with_coercion |
Member
There was a problem hiding this comment.
the MRI tests get imported from MRI ... this change might get lost later.
it would be better to move this under test/jruby/ (or write a ruby spec).
Contributor
Author
There was a problem hiding this comment.
Ah cool, thanks for the heads up. I'll move the the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.