Clear references to threads and thread contexts on teardown.#5390
Merged
enebo merged 1 commit intojruby:masterfrom Oct 31, 2018
Merged
Clear references to threads and thread contexts on teardown.#5390enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
This was referenced Oct 30, 2018
This change clears the following on JRuby runtime teardown: * The thread-local context reference in ThreadService (dereferenced entirely) * The mainContext reference in ThreadService * The mapping from native threads to RubyThread instances. This should clear all JRuby-specific runtime data attached to both Ruby and adopted Java threads. Fixes jruby#3313. Supersedes jruby#3316.
headius
force-pushed
the
clear_thread_objects
branch
from
58385cc to
9f72b0c
Compare
Member
Author
|
Re-pushed with a tweak to allow profiling to dump before clearing thread references. |
enebo
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change clears the following on JRuby runtime teardown:
(dereferenced entirely)
This should clear all JRuby-specific runtime data attached to
both Ruby and adopted Java threads.
Fixes #3313.
Supersedes #3316.