only require 'java', users should explicitly require 'jruby'#5381
only require 'java', users should explicitly require 'jruby'#5381
Conversation
|
marking for 9.2 ... its not a hard requirement, more of a discussion - we could post-pone for 9.3 |
|
I believe we should constrain require 'jruby' to only the places we know it will be used. Putting it near the top of JI makes no sense to me. So I think we should apply this PR but I also wonder why it is here at all? Do we use #reference or something somewhere? If so the second part of this PR would be to put the include wherever we do that. |
|
think it has been there historically to have |
|
9.3.0.0 seems like a good time...significant # and if this does break some extensions we have some time to get them to add a single line to fix it. |
|
okay - will update PR as this implicit |
6b11c87 to
ba4980b
Compare
40b266d to
b492769
Compare
|
PR is now ready ... the |
|
I'm approving this but it does feel a little weird now to have in any case, I'm fine going forward with this since most people don't even know about these utilities, and they're very much JRuby-specific anyway. |
seems to makes sense as using JRuby internals make the runtime "dirty"
e.g.
ObjectSpacewill end up finding invalid class pieces (e.g. for UNDEF)still, its kind of a small "break" in term-of backwards compatibility
although most scripts floating around do the explicit require 'jruby'
... before scripting with internals such as
JRuby.runtimeleft-over from #5205 as noted at #5233