[#5287] Use epoll selector for file IO on macosx#5373
Merged
headius merged 1 commit intojruby:masterfrom Oct 26, 2018
Merged
Conversation
Member
|
there seems to be an (unrelated) compilation failure with CI ... maybe you should rebase of recent master |
Contributor
Author
|
Member
|
I'm on it. |
Member
|
This may fail initially if the jnr-enxio 0.19 release has not propagated, but it's merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5287.
Without it, unit test gets stuck on the select call. See Thread dump.
It needs jnr/jnr-enxio#29 feature to avoid
KQSelectorand fallback onEpollSelector. We passisFile=trueinNativeDeviceChannelconstructor in the case of a file. This avoids getting stuck on macosx when calling kevent system call at the end of the file.kqueue does not support EOF. There is no easy way to skip select call to avoid blocking for ever.
We still want to use KQSelector for sockets. Just not vnodes.