Skip to content

enable Integer#sqrt#5367

Merged
kares merged 1 commit intojruby:masterfrom
ahorek:sqrt
Oct 14, 2018
Merged

enable Integer#sqrt#5367
kares merged 1 commit intojruby:masterfrom
ahorek:sqrt

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Oct 13, 2018

require 'benchmark/ips'

def sqrt
  1000.times do |num|
    Integer.sqrt(num)
  end
end

Benchmark.ips do |x|
  x.report('sqrt') { sqrt }
end

master

 sqrt      9.153k (±20.4%) i/s -     42.000k in   5.027226s

patch

 sqrt     16.244k (±14.2%) i/s -     79.422k in   5.063626s

@kares
Copy link
Member

kares commented Oct 14, 2018

najs, esp. since there seem to be no test broken despite the FIXME :)

@kares kares merged commit d2bc2bc into jruby:master Oct 14, 2018
@kares kares added this to the JRuby 9.2.1.0 milestone Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants