Fix toplevel method visibility in jit/fullint script scopes.#5358
Merged
headius merged 1 commit intojruby:masterfrom Oct 11, 2018
Merged
Fix toplevel method visibility in jit/fullint script scopes.#5358headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
Toplevel scopes were only getting defaulted to private visibility for the startup interpreter, which does not ever use in-IR call protocol. When the toplevel script body is first optimized to fullint or compiled to bytecode, call protocol is installed with no external preamble code to set visibility to private, so the visibility was defaulting back to public as in non-script scopes. This change adds visibility to the frame push instruction, so top- level scripts will use private in their frame push. This fixes regression in test:jruby:aot test_timeout.rb toplevel timeout test, which relied on the non-self call to timeout to see the toplevel private method and trigger method_missing. This began to fail with my timeout update because the method is now defined in Ruby code rather than manually in Java code (the latter of which explicitly set private visibility).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toplevel scopes were only getting defaulted to private visibility
for the startup interpreter, which does not ever use in-IR call
protocol. When the toplevel script body is first optimized to
fullint or compiled to bytecode, call protocol is installed with
no external preamble code to set visibility to private, so the
visibility was defaulting back to public as in non-script scopes.
This change adds visibility to the frame push instruction, so top-
level scripts will use private in their frame push.
This fixes regression in test:jruby:aot test_timeout.rb toplevel
timeout test, which relied on the non-self call to timeout to see
the toplevel private method and trigger method_missing. This began
to fail with my timeout update because the method is now defined
in Ruby code rather than manually in Java code (the latter of
which explicitly set private visibility).