[Zlib][CRC32] Trim 'start' value to 32-bit for negative long integers#5350
Merged
headius merged 1 commit intojruby:masterfrom Oct 9, 2018
adwyze:fix-negative-long-crc32
Merged
[Zlib][CRC32] Trim 'start' value to 32-bit for negative long integers#5350headius merged 1 commit intojruby:masterfrom adwyze:fix-negative-long-crc32
headius merged 1 commit intojruby:masterfrom
adwyze:fix-negative-long-crc32
Conversation
As discussed in #5290 (comment), The while loop in gf2_matrix_times should terminate after 32 iterations. That means the value of 'start' should be 0 after (start>>32). Trimming the value beyond 32 bits ensures that behavior.
prashantvithani
changed the title
prashantvithani
changed the title
Member
|
Nice, thanks! I was hoping it would be something simple like this. |
Contributor
Author
|
@headius Thanks for merging this! I was wondering if you could you tell when this change would be released? This was kind of blocker for us to migrate to JRuby. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #5290 (comment), The while loop in gf2_matrix_times should terminate after 32 iterations. That means the value of 'start' should be 0 after (start>>32). Trimming the value beyond 32 bits ensures that behavior.
FIX #5290