index error instead of argument error#5337
Merged
kares merged 1 commit intojruby:masterfrom Oct 9, 2018
Merged
Conversation
Member
|
again there's no explanation nor a test on why you're doing this change. |
Contributor
Author
|
there's a test for this behavior, but it still fails for a different reason test_aset_error jruby/test/mri/excludes/TestArray.rb Line 1 in e4aee7d jruby/test/mri/ruby/test_array.rb Line 2113 in 4e8bb26 should I duplicate it and test this separately in a jruby's test specs? |
Member
|
@ahorek that is very helpful to know, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.