Improve RubyHash#resize performance#5299
Merged
enebo merged 2 commits intojruby:masterfrom Sep 19, 2018
Merged
Conversation
as we store now the hash values, we do not need to recalculate the hashes while resizing again. Also using System.arraycopy for entries and hashes arrays seems to be faster than manually assigning them inside the loop.
from functional perspective this is not necessary as it would never reach the point to compare the hashes. However, when debugging, it helps to also see the deleted hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as we store now the hash values, we do not need to recalculate the hashes while resizing again.
Also using System.arraycopy for entries and hashes arrays seems to be faster than manually assigning them inside the loop.
Benchmark