Skip to content

Fix remaining failing tests with Enumerable#all? when given a pattern argument#5298

Merged
kares merged 1 commit intojruby:masterfrom
nomadium:fix-some-enumerable-all-tests
Sep 4, 2018
Merged

Fix remaining failing tests with Enumerable#all? when given a pattern argument#5298
kares merged 1 commit intojruby:masterfrom
nomadium:fix-some-enumerable-all-tests

Conversation

@nomadium
Copy link
Contributor

Hi folks,

This change should fix more failing tests with Enumerable#all? when given a pattern argument.

The approach is similar to what is implemented for Enumerable#any? [1]

  1. https://github.com/jruby/jruby/blob/master/core/src/main/java/org/jruby/RubyArray.java#L4435-L4440

@nomadium nomadium force-pushed the fix-some-enumerable-all-tests branch from 850019b to 3557fcf Compare September 4, 2018 08:32
@kares
Copy link
Member

kares commented Sep 4, 2018

we shall (alias) Nomadium = Enumerable for you hard work!

@kares kares added this to the JRuby 9.2.1.0 milestone Sep 4, 2018
@kares kares merged commit c3c8e14 into jruby:master Sep 4, 2018
@nomadium nomadium deleted the fix-some-enumerable-all-tests branch September 4, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants