Add Complimentary Regression Test for GH-5203#5265
Merged
enebo merged 1 commit intojruby:masterfrom Sep 19, 2018
Merged
Conversation
aryeh-looker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression test in b087544 is very good. Unlike the regression test in b087544, however, the AWS S3 SDK receives a string via a regex and encounters the same bug.
The regression test in this PR mimics the S3 SDK by receiving a string from a regex match and asserts that the string is not mutated via StringIO manipulation.
This regression test fails without b087544 , but succeeds with that fix.
Related to #5203 (comment). cc/ @kares