Conversation
... now using JRuby::Util.load_ext mechanism
contains some more compat fixes and handles completion regression since JLine 2.13 started adding ' ' after full completion ...
Member
|
The updated jruby-readline appears to be the cause of #5387 so I think we'll need to revert this for 9.2.1 and figure out what went wrong. |
kares
added a commit
to kares/jruby
that referenced
this pull request
Nov 7, 2018
on top of jrubyGH-5225 fixes restoring stty after runtime tear-down resolves jrubyGH-5387
kares
added a commit
to kares/jruby
that referenced
this pull request
Nov 9, 2018
on top of jrubyGH-5225 fixes restoring stty after runtime tear-down resolves jrubyGH-5387
kares
added a commit
that referenced
this pull request
Nov 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... now using
JRuby::Util.load_extmechanism for #5205contains a couple of interesting features/fixes - wonder why it lagged behind
e.g. OSv support, HP-UX working, avoided (class) memory leaks, printing "Display all 104 possibilities? (y or n)" on a new line, ...
UPDATE: there seems to be one visible regression under Linux - printing space after irb completion
believe we can fix that and also make jruby-readline usable as a standalone gem
... should we eventually also push to RubyGems? (would be great to test out new release under Windows)