Update specs by eregon · Pull Request #5217 · jruby/jruby

eregon · 2018-06-13T22:04:25Z

You guys should write more specs, I didn't have to sync any spec from JRuby this time ;)

eregon · 2018-06-13T22:48:57Z

Here are the failures. Of particular interest are the String case ones, which are from specs @nirvdrum added.

1)
Array#pack with :buffer option offset (@) is specified keeps buffer content if it is longer than offset FAILED
Expected "123456\x00\x00\x00ABC"
 to equal "123ABC"

/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:36:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:6:in `block in (root)'
/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

2)
Array#pack with :buffer option offset (@) is specified fills the gap with \0 if buffer content is shorter than offset FAILED
Expected "123\x00\x00\x00\x00\x00\x00ABC"
 to equal "123\x00\x00\x00ABC"

/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:42:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:6:in `block in (root)'
/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

3)
Array#pack with :buffer option offset (@) is specified does not keep buffer content if it is longer than offset + result FAILED
Expected "1234567890\x00\x00\x00ABC"
 to equal "123ABC"

/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:48:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:6:in `block in (root)'
/home/travis/build/jruby/jruby/spec/ruby/core/array/pack/buffer_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

4)
Enumerable#all? with block yields multiple arguments when each yields multiple FAILED
Expected [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
to equal [[1, 2], [3, 4, 5], [6, 7, 8, 9]]

/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/all_spec.rb:133:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/all_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

5)
Enumerable#all? when given a pattern argument ignores block ERROR
<No message>
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/all_spec.rb:147:in `block in (root)'
org/jruby/RubyEnumerable.java:1741:in `all?'
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/all_spec.rb:147:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/all_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

6)
Enumerable#all? when given a pattern argument returns false if the pattern ever returns false or nil FAILED
Expected true
 to equal false

/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/all_spec.rb:178:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/all_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

7)
Enumerable#any? with block yields multiple arguments when each yields multiple FAILED
Expected [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
to equal [[1, 2], [3, 4, 5], [6, 7, 8, 9]]

/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/any_spec.rb:146:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/any_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

8)
Enumerable#none? with a block yields multiple arguments when each yields multiple FAILED
Expected [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
to equal [[1, 2], [3, 4, 5], [6, 7, 8, 9]]

/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/none_spec.rb:102:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/none_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

9)
Enumerable#one? with a block yields multiple arguments when each yields multiple FAILED
Expected [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
to equal [[1, 2], [3, 4, 5], [6, 7, 8, 9]]

/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/one_spec.rb:92:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/enumerable/one_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

10)
Kernel#autoload when called from included module's method setups the autoload on the included module FAILED
Expected nil
to equal "/home/travis/build/jruby/jruby/spec/ruby/core/kernel/fixtures/autoload_from_included_module.rb"

/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:71:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:16:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

11)
Kernel#autoload when called from included module's method the autoload relative to the included module works ERROR
NameError: uninitialized constant KernelSpecs::AutoloadMethod::AutoloadFromIncludedModule
Did you mean?  KernelSpecs::AutoloadMethodIncluder
org/jruby/RubyModule.java:3532:in `const_missing'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:79:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:16:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

12)
Kernel.autoload when called from included module's method setups the autoload on the included module FAILED
Expected nil
to equal "/home/travis/build/jruby/jruby/spec/ruby/core/kernel/fixtures/autoload_from_included_module2.rb"

/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:137:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:100:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

13)
Kernel.autoload when called from included module's method the autoload is reacheable from the class too FAILED
Expected nil
to equal "/home/travis/build/jruby/jruby/spec/ruby/core/kernel/fixtures/autoload_from_included_module2.rb"

/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:141:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:100:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

14)
Kernel.autoload when called from included module's method the autoload relative to the included module works ERROR
NameError: uninitialized constant KernelSpecs::AutoloadMethod2::AutoloadFromIncludedModule2
Did you mean?  KernelSpecs::AutoloadMethodIncluder2
org/jruby/RubyModule.java:3532:in `const_missing'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:145:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/autoload_spec.rb:100:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

15)
Kernel#warn :uplevel keyword argument does not prepend caller information if line number is too big FAILED
Expected:
  $stderr: "warning: foo\n"
     got:
  $stderr: "org/jruby/RubyKernel.java:1272: warning: foo\n"

/home/travis/build/jruby/jruby/spec/ruby/core/kernel/warn_spec.rb:98:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/warn_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

16)
Kernel#warn :uplevel keyword argument prepends even if a message is empty or nil ERROR
TypeError: no implicit conversion of nil into String
org/jruby/RubyString.java:1152:in `+'
org/jruby/RubyKernel.java:1282:in `warn'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/fixtures/classes.rb:416:in `f1'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/fixtures/classes.rb:412:in `f2'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/fixtures/classes.rb:408:in `f3'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/fixtures/classes.rb:404:in `f4'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/warn_spec.rb:106:in `block in (root)'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/warn_spec.rb:106:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/warn_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

17)
Kernel#warn :uplevel keyword argument raises ArgumentError if passed negative value ERROR
Java::JavaLang::ArrayIndexOutOfBoundsException: -1
org.jruby.RubyKernel.warn(RubyKernel.java:1279)
org.jruby.RubyKernel$INVOKER$s$warn_DBG.call(RubyKernel$INVOKER$s$warn_DBG.gen)
org.jruby.internal.runtime.methods.JavaMethod$JavaMethodN.call(JavaMethod.java:801)
org.jruby.internal.runtime.methods.DynamicMethod.call(DynamicMethod.java:210)
org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:365)
org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:201)
org.jruby.ir.interpreter.InterpreterEngine.processCall(InterpreterEngine.java:324)
org.jruby.ir.interpreter.StartupInterpreterEngine.interpret(StartupInterpreterEngine.java:72)
org.jruby.ir.interpreter.Interpreter.INTERPRET_BLOCK(Interpreter.java:129)
org.jruby.runtime.InterpretedIRBlockBody.commonYieldPath(InterpretedIRBlockBody.java:139)
org.jruby.runtime.IRBlockBody.call(IRBlockBody.java:79)
org.jruby.runtime.Block.call(Block.java:124)
org.jruby.RubyProc.call(RubyProc.java:286)
org.jruby.RubyProc.call(RubyProc.java:266)
...

18)
Kernel#warn :uplevel keyword argument raises ArgumentError if passed -1 FAILED
Expected ArgumentError but no exception was raised (nil was returned)
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/warn_spec.rb:123:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/warn_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

19)
Marshal.dump when passed a StringIO should raise an error FAILED
Expected TypeError
but no exception was raised ("\x04\bo:\rStringIO\x00" was returned)
/home/travis/build/jruby/jruby/spec/ruby/core/marshal/dump_spec.rb:547:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/marshal/dump_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

20)
String#capitalize full Unicode case mapping updates string metadata FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/capitalize_spec.rb:44:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/capitalize_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

21)
String#capitalize! full Unicode case mapping updates string metadata FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/capitalize_spec.rb:125:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/capitalize_spec.rb:97:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

22)
String#downcase full Unicode case mapping updates string metadata FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/downcase_spec.rb:37:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/downcase_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

23)
String#downcase! full Unicode case mapping updates string metadata FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/downcase_spec.rb:120:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/downcase_spec.rb:98:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

24)
String#swapcase full Unicode case mapping updates string metadata FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/swapcase_spec.rb:37:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/swapcase_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

25)
String#swapcase! full Unicode case mapping updates string metadata FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/swapcase_spec.rb:112:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/swapcase_spec.rb:90:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

26)
String#undump Limitations cannot undump non ASCII-compatible string ERROR
RuntimeError: non-ASCII character detected
org/jruby/RubyString.java:2079:in `undump'
/home/travis/build/jruby/jruby/spec/ruby/core/string/undump_spec.rb:408:in `block in (root)'
/home/travis/build/jruby/jruby/spec/ruby/core/string/undump_spec.rb:408:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/undump_spec.rb:6:in `block in (root)'
/home/travis/build/jruby/jruby/spec/ruby/core/string/undump_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

27)
String#upcase full Unicode case mapping updates string metadata FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/upcase_spec.rb:37:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/upcase_spec.rb:5:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

28)
String#upcase! full Unicode case mapping updates string metadata for self FAILED
Expected false to be true
/home/travis/build/jruby/jruby/spec/ruby/core/string/upcase_spec.rb:117:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/string/upcase_spec.rb:95:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

29)
Thread::Backtrace::Location#base_label when call frame is inside a block returns the name of the method that contains the block FAILED
Expected "block in block_location"
 to equal "block_location"

/home/travis/build/jruby/jruby/spec/ruby/core/thread/backtrace/location/base_label_spec.rb:19:in `block in (root)'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/thread/backtrace/location/base_label_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

From https://api.travis-ci.org/v3/job/391979779/log.txt

eregon · 2018-06-13T23:13:53Z

The CI for specs passes now, I'll merge.

headius · 2018-06-28T21:27:05Z

You guys should write more specs, I didn't have to sync any spec from JRuby this time ;)

If there are no specs, it means we did not find any untested behaviors during our work since the last sync.

headius · 2018-06-28T21:28:16Z

FWIW, most of the specs that come from JRuby issues are contributed by the bug reporter directly to ruby/spec.

eregon · 2018-06-28T21:40:08Z

If there are no specs, it means we did not find any untested behaviors during our work since the last sync.

Awesome then :)
I just meant it as an encouraging statement to write more specs because there are definitely some not-so-well tested areas.

FWIW, most of the specs that come from JRuby issues are contributed by the bug reporter directly to ruby/spec.

Right, thank you for encouraging them to contribute to ruby/spec!

Both are fine for me.
One advantage of having them directly in JRuby is they can be run from the moment the PR is merged, e.g. to ensure a fix does not regress and pass the spec. One advantage of having them directly in ruby/spec is they might get more initial spec review.

headius · 2018-06-30T01:28:27Z

One advantage of having them directly in ruby/spec is they might get more initial spec review.

That's the main reason I usually direct them to ruby/spec...especially when they're adding specs for something that never had specs before, rather than just adding a couple cases.

Update to ruby/spec@5f7b4a6

a5af7da

eregon requested review from enebo and headius June 13, 2018 22:04

eregon added 2 commits June 14, 2018 00:41

Add tags for failing specs

dd5a798

Update Array#pack buffer tags

d126fcb

eregon merged commit c93ba6f into jruby:master Jun 13, 2018

eregon deleted the update-specs branch June 13, 2018 23:14

kares added this to the Non-Release milestone Jun 14, 2018

eregon mentioned this pull request Jun 14, 2018

The coderange is not properly recomputed after upcase/downcase/swapcase #5218

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update specs#5217

Update specs#5217
eregon merged 3 commits intojruby:masterfrom
eregon:update-specs

eregon commented Jun 13, 2018

Uh oh!

eregon commented Jun 13, 2018 •

edited

Loading

Uh oh!

eregon commented Jun 13, 2018

Uh oh!

headius commented Jun 28, 2018

Uh oh!

headius commented Jun 28, 2018

Uh oh!

eregon commented Jun 28, 2018

Uh oh!

headius commented Jun 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

eregon commented Jun 13, 2018

Uh oh!

eregon commented Jun 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eregon commented Jun 13, 2018

Uh oh!

headius commented Jun 28, 2018

Uh oh!

headius commented Jun 28, 2018

Uh oh!

eregon commented Jun 28, 2018

Uh oh!

headius commented Jun 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eregon commented Jun 13, 2018 •

edited

Loading