Skip to content

Clone proc blocks as well so they have their own frame etc.#5214

Merged
headius merged 1 commit intojruby:masterfrom
headius:clone_proc_for_define
Jun 12, 2018
Merged

Clone proc blocks as well so they have their own frame etc.#5214
headius merged 1 commit intojruby:masterfrom
headius:clone_proc_for_define

Conversation

@headius
Copy link
Member

@headius headius commented Jun 11, 2018 •
edited
Loading

Fixes #2212.

@headius headius added this to the JRuby 9.2.1.0 milestone Jun 11, 2018
@headius
Copy link
Member Author

headius commented Jun 11, 2018 •
edited
Loading

This also needs specs. The example case from #2212 also fails to super properly without this patch:

class A
  def a
    p :a
  end
end

PROC = proc {p :proc; super}

class B < A
  define_method(:a, PROC)
  define_method(:b, PROC)
end

B.new.a

Which produces the following error (without my fix):

$ jruby blah2.rb 
:proc
NoMethodError: super: no superclass method `b' for #<B:0x27f723>
  block in blah2.rb at blah2.rb:7
             <main> at blah2.rb:14

@headius headius force-pushed the clone_proc_for_define branch from 658bae1 to f03fc20 Compare June 11, 2018 19:12
@headius headius mentioned this pull request Jun 11, 2018
Closed
@headius headius added the core label Jun 12, 2018
@headius headius merged commit 13130e2 into jruby:master Jun 12, 2018
@headius headius deleted the clone_proc_for_define branch June 12, 2018 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

JRuby 9.2.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@headius