Remove hack for FileUtils.mv due to incorrect error raised from File.rename#5168
Merged
Remove hack for FileUtils.mv due to incorrect error raised from File.rename#5168
Conversation
This fix is needed because Bundler now vendors an MRI version of fileutils that does not include our hacks for the incorrect EACCES error. That is a larger issue since there's other hacks we have not eliminated, but this fixes a primary issue bundling libraries.
headius
added a commit
to jruby/ruby
that referenced
this pull request
May 13, 2018
headius
added a commit
to jruby/ruby
that referenced
this pull request
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MRI, File.rename will raise an EXDEV if the rename is attempted with paths that span devices (mounts). Up until this PR, we would raise EACCES in such a situation, requiring us to modify fileutils.rb to deal with both errors.
Because this is tweaking a very core behavior of File and FileUtils, I'm pushing to a branch to see how it affects our test runs.
This fix is an attempt to deal with at least part of Bundler's vendoring of a non-JRuby fileutils.rb. See rubygems/bundler#6532.