Skip to content

Update ruby/spec#5064

Merged
eregon merged 2 commits intomasterfrom
update-specs
Feb 27, 2018
Merged

Update ruby/spec#5064
eregon merged 2 commits intomasterfrom
update-specs

Conversation

@eregon
Copy link
Member

@eregon eregon commented Feb 27, 2018

No description provided.

@eregon eregon requested review from enebo and headius February 27, 2018 20:21
@eregon
Copy link
Member Author

eregon commented Feb 27, 2018

The PR should be merged with "Rebase and merge", not squashed and not using a merge commit.

@eregon
Copy link
Member Author

eregon commented Feb 27, 2018

The only extra failure is:

     [exec] 15)
     [exec] String#freeze produces the same object whenever called on an instance of a literal in the source FAILED
     [exec] Expected "abc"
     [exec]  to be identical to "abc"
     [exec] 
     [exec] /home/travis/build/jruby/jruby/spec/ruby/core/string/freeze_spec.rb:6:in `block in (root)'
     [exec] org/jruby/RubyBasicObject.java:2595:in `instance_eval'
     [exec] org/jruby/RubyEnumerable.java:1704:in `all?'
     [exec] org/jruby/RubyArray.java:1777:in `each'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/core/string/freeze_spec.rb:3:in `<main>'
     [exec] org/jruby/RubyKernel.java:987:in `load'
     [exec] org/jruby/RubyBasicObject.java:2595:in `instance_eval'
     [exec] org/jruby/RubyArray.java:1777:in `each'

But that seems flaky and I cannot reproduce locally.

@eregon eregon merged commit debc0d1 into master Feb 27, 2018
@eregon eregon deleted the update-specs branch February 27, 2018 20:51
@headius
Copy link
Member

headius commented Feb 27, 2018

Thanks! If the extra failure continues to flake we'll look into it.I thought we'd fixed this on master.

@headius headius added this to the JRuby 9.2.0.0 milestone Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@headius headius Awaiting requested review from headius

@enebo enebo Awaiting requested review from enebo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eregon @headius