Fix test coerce2 for master branch#5022
Merged
kares merged 3 commits intojruby:masterfrom Jan 31, 2018
Merged
Conversation
Currently `Numeric#%` is defined in the same way as `Numeric#modulo`. Ref: https://github.com/ruby/ruby/blob/v2_4_0/numeric.c#L5240-L5241
Currently these methods are not defined on `Rational`.
Currently this method is not defined on `Rational`.
Merged
Member
|
Thanks Yui, indeed resolves the issue. #5006 was merged over from 9.1 so I wonder what happened. |
Member
|
think the jruby-9.1 merge must have had conflicts at RubyRational.java and wasn't resolved properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is porting of #5006.
Method names modulo19, op_idiv19 and op_mod19 have been changed on master branch.
So we should porting the commit manually.
I hope this PR fix "test:mri*".