Do modifyCheck for each pair in Array#sort!#5021
Merged
enebo merged 1 commit intojruby:masterfrom Feb 1, 2018
Merged
Conversation
as calling comparison could freeze the Array and should trigger a RuntimeError.
Member
|
Cross-referencing links: only informative and additive, to describe this change. The test was: def test_sort_bang_with_freeze
ary = []
o1 = Object.new
o1.singleton_class.class_eval {
define_method(:<=>) {|v|
ary.freeze
1
}
}
o2 = o1.clone
ary << o1 << o2
orig = ary.dup
assert_raise(FrozenError, "frozen during comparison") {ary.sort!}
assert_equal(orig, ary, "must not be modified once frozen")
endThis Git blame view shows that 2 months ago, there was a change so that the |
Contributor
Author
|
@olleolleolle @kares should I change it in this PR? Because this one is targeting master but I guess the change is for 2.5, right? |
Member
|
@ChrisBr My additional comment about the evolution of Ruby was only informative. My take: Keep them separate, take no further action for this PR. |
Member
|
fixed an existing spec, seems no new ones broke. so all should be good as is - @enebo okay to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as calling comparison could freeze the Array and should trigger a RuntimeError.