Conversation
Currently `Numeric#%` is defined in the same way as `Numeric#modulo`. Ref: https://github.com/ruby/ruby/blob/v2_3_0/numeric.c#L4179-L4180
Currently these methods are not defined on `Rational`.
Currently this method is not defined on `Rational`.
Now `test_coerce2` does not fail.
Member
|
@yui-knk just waiting for test:mri to finish and this looks good. Weirded out that '.div' is no longer there but I see it is not in Ruby docs for 2.2? I don't know the history of that merthod though. |
Contributor
Author
|
Maybe ruby/ruby@d82ed7e this commit removed |
Member
|
@yui-knk yeah it is strange to see Ruby API shrink :) |
kares
added a commit
that referenced
this pull request
Jan 31, 2018
Fix test coerce2 for master branch since merge of #5006 wasn't handled properly due changes in RubyRational.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.