Ruby 2.5: Add String#delete_prefix and String#delete_prefix!#4993
Merged
enebo merged 2 commits intojruby:ruby-2.5from Jan 25, 2018
Merged
Ruby 2.5: Add String#delete_prefix and String#delete_prefix!#4993enebo merged 2 commits intojruby:ruby-2.5from
enebo merged 2 commits intojruby:ruby-2.5from
Conversation
Contributor
Author
|
Please note that the last test in test_delete_prefix! currently fails: I'm wondering what I do wrong here as I do a frozen check in delete_prefix! |
to remove leading substr. https://bugs.ruby-lang.org/issues/12694 Support jruby#4876
c&p from 10082360b9124c3eaabfccf4fe10a3640c40a05e. jruby#4876.
5958f36 to
3817407
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See feature https://bugs.ruby-lang.org/issues/12694
#4876