Skip to content

Check an encoding of string#4992

Merged
enebo merged 1 commit intojruby:jruby-9.1from
yui-knk:fix_test_symbol_encoding
Jan 20, 2018
Merged

Check an encoding of string#4992
enebo merged 1 commit intojruby:jruby-9.1from
yui-knk:fix_test_symbol_encoding

Conversation

@yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Jan 20, 2018

MRI checks an encoding of string is broken
before conveting string to symbol.
This commit will fix #test_symbol_encoding.

Ref: https://github.com/ruby/ruby/blob/v2_5_0/symbol.c#L432

MRI checks an encoding of string is broken
before conveting string to symbol.
This commit will fix `#test_symbol_encoding`.

Ref: https://github.com/ruby/ruby/blob/v2_5_0/symbol.c#L432
@enebo enebo added this to the JRuby 9.1.16.0 milestone Jan 20, 2018
@enebo enebo merged commit 2666447 into jruby:jruby-9.1 Jan 20, 2018
@enebo
Copy link
Member

enebo commented Jan 20, 2018

A recent java 9 change has made seeing results of this difficult but it looks reasonable.

@yui-knk yui-knk deleted the fix_test_symbol_encoding branch January 20, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants