Conversation
kares
added a commit
to kares/jruby
that referenced
this pull request
Jan 19, 2018
* master: (270 commits) Mild refactoring of invokers code (came from bytelist_love work). As I need to make changes to generated code I am trying to comment/document some portions and reduce some duplication when possible. resolve regression with Set impl - SortedSet did not clone/dup properly be explicit about non-happening exception + avoid dynamic ** call cleanup Rational - use RubyInteger#idiv so we're no hitting call-sites introduce long overloads for common (integer) ops + start using them raise ArgumentError use encoding none for n/N option fix IOOBE in test_regexp quote Fix documents Revise COPYRIGHT YEAR use num2int in StringIO#ungetc Fix a typo Remove not used methods (jruby#4973) Inline the regexp validation inside ParserSupport Simplify the regexp validation logic Add support for validating Regexp in Ripper Make sure to clear $! when rescuing RaiseException Align validation code with MRI Move Regexp checking from ParserSupport to Lexer Extract parseRegexpFlags to Lexer ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.