Conversation
Contributor
Author
|
Please note that the test will fail because of this issue |
kares
requested changes
Jan 9, 2018
| if (tmp.isNil()) { | ||
| modifyCheck(context.runtime); | ||
| } else { | ||
| System.out.println("rehash"); |
|
|
||
| @JRubyMethod(name = "reset") | ||
| public IRubyObject reset(ThreadContext context) { | ||
| IRubyObject tmp = TypeConverter.checkHashType(context.runtime, this.hash); |
Member
There was a problem hiding this comment.
this.hash is 'internal' -> can not be changed (wout hacks) on .rb end ... + its already of type RubyHash
Contributor
Author
There was a problem hiding this comment.
Not sure if I understand correct :/ What should I use instead this.hash.
The type check is adapted from the MRI implementation.
Member
There was a problem hiding this comment.
The type check is adapted from the MRI implementation.
figured, since this as a native part, specific to JRuby, just logically simplify what makes sense.
since you have a RubyHash hash you do not need any type-checking whether its a Hash ...
ChrisBr
force-pushed
the
feature/set-rehash
branch
2 times, most recently
from
0c36854 to
5f7e117
Compare
https://bugs.ruby-lang.org/issues/6589 Tests c&p from ruby/ruby@8c90432. Supports jruby#4876
ChrisBr
force-pushed
the
feature/set-rehash
branch
from
5f7e117 to
54b0eeb
Compare
kares
approved these changes
Jan 10, 2018
Member
|
Thanks Chris, well done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/6589
Tests c&p from ruby/ruby@8c90432.
Supports #4876