Revert to using weakref.rb, since it's based on a proper weak map.#4955
Merged
Revert to using weakref.rb, since it's based on a proper weak map.#4955
Conversation
This library used to use _id2ref (an internal API) for its implementation. This was not only very VM-specific (most VMs can't reconstitute an object reference given only its ID) but also buggy (an evacuated reference might get overlaid by a new object due to MRI's conservative GC and use of address for IDs. The new implementation of the library uses ObjectSpace::WeakMap, which is considered an internal API but which exposes an opaque weak identity map that can be implemented on other VMs more more easily. Given this and our need to continue descending from Delegate, moving back to the Ruby version may make sense.
Member
Author
Member
|
for posterity I liked the notion of leaning on this library to only have one thing we need to maintain involving weak references :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as PR since this is a nontrivial change to put into 9.1, even though it aligns us better with MRI. Primary reason for this change is to get weakref specs to be more reliable...perhaps bringing our impl closer to theirs will do this.
This library used to use _id2ref (an internal API) for its
implementation. This was not only very VM-specific (most VMs
can't reconstitute an object reference given only its ID) but also
buggy (an evacuated reference might get overlaid by a new object
due to MRI's conservative GC and use of address for IDs.
The new implementation of the library uses ObjectSpace::WeakMap,
which is considered an internal API but which exposes an opaque
weak identity map that can be implemented on other VMs more
more easily. Given this and our need to continue descending from
Delegate, moving back to the Ruby version may make sense.