Merged
Conversation
enebo
requested changes
Jan 8, 2018
Member
enebo
left a comment
enebo
left a comment
There was a problem hiding this comment.
Tiny style requests but as you are contributing more I will slowly give you small changes like this to match general style.
| */ | ||
| @JRubyMethod(name = "slice", rest = true) | ||
| public RubyHash slice(final ThreadContext context, final IRubyObject[] args) { | ||
| RubyHash result = newHash(getRuntime()); |
Member
There was a problem hiding this comment.
Can you change this to context.runtime?
| for (int i = 0; i < args.length; i++) { | ||
| IRubyObject key = args[i]; | ||
| IRubyObject value = this.internalGet(key); | ||
| if(value != null) |
Member
There was a problem hiding this comment.
if (value != null) { // space after if and we only allow non-curly if it is all on one line.
for Ruby 2.5 support as in https://bugs.ruby-lang.org/issues/8499 stated. jruby#4876
ChrisBr
force-pushed
the
feature/array-slice
branch
from
5e74646 to
cfae4b2
Compare
Contributor
Author
|
@enebo thanks, updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for Ruby 2.5 support as in https://bugs.ruby-lang.org/issues/8499 stated.
#4876
Tests are already in master, https://github.com/jruby/jruby/blob/7bd10a61c70d7ab271f5a1403b64ef37eaaf036a/spec/ruby/core/hash/slice_spec.rb
Commit: 75e4522#diff-a265476d146c86ed0f4352a5735b7e4b
Do we want to cherry-pick the tests to ruby-2.5 branch?