Set original Module to definedClass of methods#4944
Closed
yui-knk wants to merge 1 commit intojruby:masterfrom
Closed
Set original Module to definedClass of methods#4944yui-knk wants to merge 1 commit intojruby:masterfrom
yui-knk wants to merge 1 commit intojruby:masterfrom
Conversation
Set original Module to definedClass of methods when
new methods are defined to PrependedModule.
Before this commit, definedClass of method a
is class c but definedClass of method b
is PrependedModule:
```
M = Module.new
c = Class.new {
def a; end
prepend M
def b; end
}
```
This commit will set definedClass of method b
to class c and fix `TestMethod#test_alias_owner`.
Member
|
I will review for inclusion in 9.1.16. |
headius
approved these changes
Jan 8, 2018
Member
Member
|
Thank you for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set original Module to definedClass of methods when
new methods are defined to PrependedModule.
Before this commit, definedClass of method a
is class c but definedClass of method b
is PrependedModule:
This commit will set definedClass of method b
to class c and fix
TestMethod#test_alias_owner.