Implement Dir.children by nomadium · Pull Request #4941 · jruby/jruby

nomadium · 2018-01-05T17:04:53Z

Hi folks,

This is another feature targeting Ruby 2.5 [1]: Dir.children (feature #11302).

Notes:

The tests are copied from MRI.
I also cherry-picked a commit [2] from master to be able to use Java8 lambda expressions. If that's not OK, this PR could wait until that change is merged in ruby-2.5 branch; if this is the right approach, of course.

Thanks for your review and feedback.

For more information, please see feature #11302.

headius and others added 3 commits January 5, 2018 15:58

Set source to Java 8 so we can use lambdas.

dd19fb3

Implement Dir.children

f5a7ef6

For more information, please see feature #11302.

Add MRI tests for Dir.children

5233dfd

enebo added this to the JRuby 9.3.0.0 milestone Jan 5, 2018

enebo merged commit b9c1195 into jruby:ruby-2.5 Jan 5, 2018

nomadium deleted the implement-dir-children branch January 10, 2018 20:50

enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Provide feedback